[PATCH 1 of 6] sslutil: remove ui from sslkwargs (API)

Yuya Nishihara yuya at tcha.org
Thu May 26 10:03:44 EDT 2016


On Wed, 25 May 2016 20:03:50 -0700, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc at gmail.com>
> # Date 1464230602 25200
p> #      Wed May 25 19:43:22 2016 -0700
> # Node ID 62c63aafbff472307fcf4624d63d691f769b4fb2
> # Parent  ee935a6e1ea2894c16e866bca25591aa93fb566d
> sslutil: remove ui from sslkwargs (API)

The series looks great, queued with a minor tweak. Thanks.

> --- a/mercurial/mail.py
>      if (starttls or smtps) and verifycert:
>          sslkwargs = sslutil.sslkwargs(ui, mailhost)
> -    else:
> -        # 'ui' is required by sslutil.wrapsocket() and set by sslkwargs()
> -        sslkwargs = {'ui': ui}

This would introduce a temporary name error. I've fixed in flight, but anyway
the end result is the same.


More information about the Mercurial-devel mailing list