[PATCH v3] py3: conditionalize the cPickle import

timeless timeless at gmail.com
Tue May 31 15:00:10 EDT 2016


The reason I've been adding things to util is because mpm objected to
copy-paste code elsewhere.

I agree w/ him. (I should just send my series which has this change...)

On Tue, May 31, 2016 at 11:18 AM, Pulkit Goyal <7895pulkit at gmail.com> wrote:
> On Tue, May 31, 2016 at 8:45 PM, Bryan O'Sullivan <bos at serpentine.com> wrote:
>> I would suggest writing functions for loading and dumping pickles in util
>> instead. This will eliminate all the duplicated code, and will also let you
>> write the module loading code lazily.
>>
> There were just five files using the library, so adding it in the util
> was an overkill. Most of the libraries added in util are used widely
> in the codebase.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list