[PATCH 2 of 5] adjustlinkrev: use C implementation to test ancestor if possible
Jun Wu
quark at fb.com
Tue Nov 1 07:01:51 EDT 2016
Excerpts from Jun Wu's message of 2016-11-01 09:33:10 +0000:
> https://www.mercurial-scm.org/repo/hg/rev/9372180b8c9b#l1.44
> + fctx._ancestrycontext = ac
> + fctx._descendantrev = rev
>
> _ancestrycontext and _descendantrev conflicts. We only use one of them.
> So it seems _ancestrycontext can be dropped here, because we have set
> _descendantrev.
This is not very accurate. We only use one of _ancestrycontext and
_descendantrev for changelog.i walk, but for changelog.d, it uses
_descendantrev only. That said, since the C implementation is faster, I
think dropping _ancestrycontext can actually speed up things, unless a file
has been renamed hundreds of times.
More information about the Mercurial-devel
mailing list