[PATCH 2 of 2] changegroup: use changelogrevision()

Gregory Szorc gregory.szorc at gmail.com
Tue Nov 1 21:29:38 EDT 2016


# HG changeset patch
# User Gregory Szorc <gregory.szorc at gmail.com>
# Date 1478050149 25200
#      Tue Nov 01 18:29:09 2016 -0700
# Node ID 0bf5f704d2d99965df476e5e90a517b805ee08aa
# Parent  9cd491f108689228e93b1247772aba56786afcd7
changegroup: use changelogrevision()

Using offsets for accessing changelog entries isn't very readable.
As a bonus, changelog.changelogrevision() also accepts a revision,
so we don't need to perform the inline node resolution either.

diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py
--- a/mercurial/changegroup.py
+++ b/mercurial/changegroup.py
@@ -334,7 +334,7 @@ class cg1unpacker(object):
                     ml = repo.manifestlog
                     # validate incoming csets have their manifests
                     for cset in xrange(clstart, clend):
-                        mfnode = cl.read(cl.node(cset))[0]
+                        mfnode = cl.changelogrevision(cset).manifest
                         mfest = ml[mfnode].readdelta()
                         # store file nodes we must see
                         for f, n in mfest.iteritems():


More information about the Mercurial-devel mailing list