[PATCH] help: show help for disabled extensions(issue5228)

Yuya Nishihara yuya at tcha.org
Sat Nov 5 23:08:39 EDT 2016


On Sun, 06 Nov 2016 07:02:56 +0530, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit at gmail.com>
> # Date 1478395471 -19800
> #      Sun Nov 06 06:54:31 2016 +0530
> # Node ID 691d3960ba61d07db8d34f5ca2c148ecb32f4f7c
> # Parent  b5fc4e71286dd4f33336e4f38e0b9fb17f51f1e3
> help: show help for disabled extensions(issue5228)

> --- a/mercurial/extensions.py	Sun Nov 06 04:36:26 2016 +0530
> +++ b/mercurial/extensions.py	Sun Nov 06 06:54:31 2016 +0530
> @@ -426,7 +426,7 @@
>          file.close()
>  
>      if doc: # extracting localized synopsis
> -        return gettext(doc).splitlines()[0]
> +        return gettext(doc)
>      else:
>          return _('(no help text available)')
>  
> @@ -446,7 +446,7 @@
>  
>      exts = {}
>      for name, path in paths.iteritems():
> -        doc = _disabledhelp(path)
> +        doc = _disabledhelp(path).splitlines()[0]

_disabledhelp(path) may return None on IOError.

>          if doc:
>              exts[name] = doc

Other than that, the patch looks good to me.


More information about the Mercurial-devel mailing list