[PATCH STABLE V2] hgweb: cache fctx.parents() in annotate command (issue5414)

Yuya Nishihara yuya at tcha.org
Tue Nov 8 09:21:51 EST 2016


On Mon, 7 Nov 2016 17:32:40 +0000, Jun Wu wrote:
> Excerpts from Gregory Szorc's message of 2016-11-07 09:29:40 -0800:
> > Could we change basefilectx.annotate() to return a rich data structure
> > instead of a list of tuples? That data structure could have the cached
> > parents and other reusable cache data (which could be passed into
> > subsequent calls if needed).
> 
> It's already returning "fctx", which is rich...

True. To be clear, I don't like the idea to make the API more complicated
just because our rich data structure "fctx" has a poor performance.


More information about the Mercurial-devel mailing list