[PATCH 1 of 3 V2] cmdutil: add support for evolution "troubles" display in changeset_printer

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Nov 10 12:05:22 EST 2016



On 11/10/2016 07:56 AM, Denis Laxalde wrote:
> Augie Fackler a écrit :
>> On Tue, Nov 08, 2016 at 03:19:55PM +0100, Denis Laxalde wrote:
>>> > # HG changeset patch
>>> > # User Denis Laxalde <denis.laxalde at logilab.fr>
>>> > # Date 1476094018 -7200
>>> > #      Mon Oct 10 12:06:58 2016 +0200
>>> > # Node ID 8be06285117259ddd122201b1e0428711c0e2a6b
>>> > # Parent  d06c049695e6ad3219e7479c65ce98a2f123e878
>>> > # EXP-Topic evolve-ui
>>> > cmdutil: add support for evolution "troubles" display in
>>> changeset_printer
>>> >
>>> > Add a "troubles" line in changeset header along with a couple of
>>> labels on
>>> > "log.changeset" line to indicate whether a changeset is troubled or
>>> not and
>>> > which kind trouble occurs.
>> I'm -0 on the word "troubles": it feels wrong in a way I'm having
>> trouble describing. It definitely feels odd to have a plural for the
>> label (the line for tags is "tag:" after all) - maybe "trouble:" would
>> be better?
>>
>> (I'm very open to better word choices here than trouble, but I have
>> none to offer.)
>>
>
> How about "stability"? If it feels strange to only have it displayed
> when there are "troubles", we may also insert it in the debug section as
> `stability: stable`.

I do not think it is suitable, stability does not really fit for 
"divergent" or "bumped" and too linked to "unstable"

In addition, trouble is really a list of 0-N element, "stable" have 
nothing to do in it and imply a more binary "stable/unstable" mode.

I really advise we move forward with trouble and have naming discussion 
on another thread/wiki page.

Cheers

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list