Fixing .hg file open ordering

[Bryan O'Sullivan]

On Thu, Nov 10, 2016 at 2:29 AM, Durham Goode <durham at fb.com> wrote:

> We worked out a solution to Bryan’s main concern, but there hasn’t been
> any discussion of my main proposal.  Internally we worked around it by
> forcing bookmarks and the changelog to load in the right order very early
> during repo setup, but that’s a hack and doesn’t address the greater
> problem.
>

For the Real Problem (TM), I'd rather try the simpler solution first, of
reading the bookmarks file in the changelog constructor, then splitting it
into lines in the bmstore constructor. I'd hope that could be both
lightweight enough that it could avoid a performance hit, and unlikely
enough to introduce bugs later on that we wouldn't have to worry about a
more heavyweight "make bugs impossible" solution. If I turn out to be wrong
and we need something more formal (which we've gotten away without for
years with revlogs, FWIW), we haven't really lost much.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20161110/93157c12/attachment.html>