[PATCH 5 of 9 V6] bookmarks: add srchex param to updatefromremote

Stanislau Hlebik stash at fb.com
Fri Nov 11 07:01:31 EST 2016


That should be fine

On 11/11/16, 11:59 AM, "Pierre-Yves David" <pierre-yves.david at ens-lyon.org> wrote:

    
    
    On 11/11/2016 11:29 AM, Stanislau Hlebik wrote:
    > Not sure I fully understand your idea.
    > Do you suggest to rewrite bookmarks.compare and bookmarks.updatefromremote to accept only binary nodes?
    
    Yes, it would like it would make more sense.
    
    If I understand your series correctly, we otherwise get in a situation 
    where a caller with the binary data has to convert them to hex and the 
    function internal have to convert thing again because internal storage 
    is node. If everybody were talking node the situation would be simpler.
    
    Does this make sense ?
    
    -- 
    Pierre-Yves David
    



More information about the Mercurial-devel mailing list