[PATCH 6 of 9 V6] bundle2: add `bookmarks` part handler
Stanislau Hlebik
stash at fb.com
Fri Nov 11 07:04:51 EST 2016
BTW, how do you think it should look like?
Do you want to introduce another type of categories in unbundlerecords or just rewrite categories whenever a new bookmark category is added?
On 11/11/16, 11:50 AM, "Stanislau Hlebik" <stash at fb.com> wrote:
I think we can but it would require a bit of rewriting in unbundlerecords.
On 11/10/16, 5:39 PM, "Pierre-Yves David" <pierre-yves.david at ens-lyon.org> wrote:
On 11/02/2016 10:56 AM, Stanislau Hlebik wrote:
>
>
> On 10/14/16, 2:28 AM, "Pierre-Yves David" <pierre-yves.david at ens-lyon.org> wrote:
>
> What is your plan regarding hooks execution here?
>
> I planned to add it when I’m going to work on push
>
> How do you handle cases where the part exist multiple time in the bundle ?
>
> Is there a problem with multiple parts? `op.records.add('bookmarks', bookmarks)` appends bookmarks from each part so it should work fine.
Yes but it adds them as multiple items instead of a unified dictionnary,
this seems strange. Could we have them as a single dict instead?
--
Pierre-Yves David
More information about the Mercurial-devel
mailing list