[PATCH 02 of 10 V8] bookmarks: introduce listbookmarks()

[Pierre-Yves David]

On 11/12/2016 11:41 PM, Gregory Szorc wrote:
> On Sat, Nov 12, 2016 at 12:19 PM, Stanislau Hlebik <stash at fb.com
> <mailto:stash at fb.com>> wrote:
>
>     # HG changeset patch
>     # User Stanislau Hlebik <stash at fb.com <mailto:stash at fb.com>>
>     # Date 1478980589 28800
>     #      Sat Nov 12 11:56:29 2016 -0800
>     # Branch stable
>     # Node ID 13b3e16c68d303a523550980d7739bb676420851
>     # Parent  fe9e78883230a875ae7acf6c7a5b324c1d9016f5
>     bookmarks: introduce listbookmarks()
>
>     `bookmarks` bundle2 part will work with binary nodes.
>     To avoid unnecessary conversions between binary and hex nodes
>     let's add `listbookmarks()` that returns binary nodes.
>
>
> Between this and part 1, you've introduced API compatibility breakage
> without an "(API)" annotation in the commit message.
>
> I'm not sure why you've done it this way. Introducing
> `listbookmarksbin()` gets you to a near identical end state without the
> API breakage.

Having a different function name seems like a good idea. We could add a 
deprecation warning on the old one. (and drop it when due)

Cheers,

-- 
Pierre-Yves David