[PATCH 1 of 3] patchbomb: introduce new option --git-format-patch

Yuya Nishihara yuya at tcha.org
Sun Nov 20 04:47:28 EST 2016


On Thu, 17 Nov 2016 13:44:46 -0800, Sean Farley wrote:
> Henning Schild <henning at hennsch.de> writes:
> > # HG changeset patch
> > # User Henning Schild <henning at hennsch.de>
> > # Date 1478958881 -3600
> > #      Sat Nov 12 14:54:41 2016 +0100
> > # Node ID 7885eea6837bbb30c12e0833b71a6691008b489e
> > # Parent  bf876ac433c1859ab61d66ddf786049fd6e6bea8
> > patchbomb: introduce new option --git-format-patch
> 
> As I mentioned before, I'd rather not have a new option. If we could do
> this with templates, then you could just alias that:
> 
> [templates]
> gitemail = "{foo} {bar}"
> 
> [alias]
> gitemail = email -T "{gitemail}"

Yeah, I like the templating idea, but that would require a fair amount of work,
for example:

 1. drop internal opts['patches'] support (which would be unused now)
 2. refactor _getpatchmsgs(), _getpatches() and makepatch()
 3. generate patch header by templater or formatter

So if it's important to support git-style diffstat, I think new option or config
knob is okay.


More information about the Mercurial-devel mailing list