[PATCH 04 of 11] httppeer: use compression engine API for decompressing responses

Augie Fackler raf at durin42.com
Mon Nov 21 17:28:41 EST 2016


> On Nov 21, 2016, at 17:27, Gregory Szorc <gregory.szorc at gmail.com> wrote:
> 
> nit: I think you could use super(readerproxy, self).read() here (but
> do this as a follow-up if you agree with the idea)
> 
> Fun fact: I did this initially and ran into a wonky failure about super expecting a type not a classobj or some other esoteric error I had never seen before. I think this was due to the built-in file object type not behaving like a real class/type. I could reproduce and add an inline comment on why super isn't used if you want.

Yes, please do as a follow-up once this lands (I've already got 1-5 prepped to land).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20161121/9873da11/attachment.html>


More information about the Mercurial-devel mailing list