[PATCH 1 of 2] dispatch: move part of callcatch to scmutil

Yuya Nishihara yuya at tcha.org
Thu Nov 24 08:28:28 EST 2016


On Thu, 24 Nov 2016 01:17:49 +0000, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1479948520 0
> #      Thu Nov 24 00:48:40 2016 +0000
> # Node ID c76f0d4bdee6bfbd7bda771d5c05939d1d4cb132
> # Parent  7ef2ebf5cdf91192a66b461ff56f653a65e65dd7
> # Available At https://bitbucket.org/quark-zju/hg-draft
> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r c76f0d4bdee6
> dispatch: move part of callcatch to scmutil

Queued these, thanks.

> -    except ImportError as inst:
> -        ui.warn(_("abort: %s!\n") % inst)
> -        m = str(inst).split()[-1]
> -        if m in "mpatch bdiff".split():
> -            ui.warn(_("(did you forget to compile extensions?)\n"))
> -        elif m in "zlib".split():
> -            ui.warn(_("(is your Python install correct?)\n"))

This seems better belonging to the high-level callcatch(), but anyway it looks
like a moot. If C extensions aren't compiled at all, ImportError would be
raised earlier.


More information about the Mercurial-devel mailing list