[PATCH] ui: use try..finally in configoverride

[Kostia Balytskyi]

On 11/27/16, 9:10 AM, "Mercurial-devel on behalf of Yuya Nishihara" <mercurial-devel-bounces at mercurial-scm.org on behalf of yuya at tcha.org> wrote:

    On Sat, 26 Nov 2016 09:14:46 -0800, Gregory Szorc wrote:
    > # HG changeset patch
    > # User Gregory Szorc <gregory.szorc at gmail.com>
    > # Date 1480180481 28800
    > #      Sat Nov 26 09:14:41 2016 -0800
    > # Node ID ace32ef8bb5a16683e0312d38e4ff5aa9abfc911
    > # Parent  906a7d8e969552536fffe0df7a5e63bf5d79b34b
    > ui: use try..finally in configoverride
    > 
    > @contextmanager almost always have their "yield" inside a try..finally
    > block. This is because if the calling code inside the activated
    > context manager raises, the code after the "yield" won't get
    > executed. A "finally" block, however, will get executed in this
    > scenario.
    
    Sure, queued, thanks.

I did not know about this, should’ve read the docs more carefully. Thanks!
    _______________________________________________
    Mercurial-devel mailing list
    Mercurial-devel at mercurial-scm.org
    https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel&d=DgIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=Pp-gQYFgs4tKlSFPF5kfCw&m=ovbkX-mbuGLQiRqmUixTyjQmk3Y5x_gRDg067rRv02s&s=7mpE6rQbWryTUWe0KfxuoVfGNmRz-dnxccmbpo6fIDM&e=