[PATCH v3] lazymanifest: write a more efficient, pypy friendly version of lazymanifest

Maciej Fijalkowski fijall at gmail.com
Sat Oct 1 08:38:21 UTC 2016


Fixed, it's error reporting and making sure we truncate the 22 length hash

On Fri, Sep 30, 2016 at 12:06 AM, Augie Fackler <raf at durin42.com> wrote:
> On Wed, Sep 28, 2016 at 01:47:32PM +0200, Maciej Fijalkowski wrote:
>> # HG changeset patch
>> # User Maciej Fijalkowski <fijall at gmail.com>
>> # Date 1473680234 -7200
>> #      Mon Sep 12 13:37:14 2016 +0200
>> # Node ID 2c852d298fbf87c5bc0ad7b65563212169915ab3
>> # Parent  df05c43bd1e64f1620d0b2e502f4603c1e5a8341
>> lazymanifest: write a more efficient, pypy friendly version of lazymanifest
>
>  (cd tests && pypy run-tests.py test-manifest.py )
>
>  --- /usr/local/google/home/augie/Programming/hg/crew/tests/test-manifest.py.out
>  +++ /usr/local/google/home/augie/Programming/hg/crew/tests/test-manifest.py.err
>  @@ -0,0 +1,24 @@
>  +FAIL: testNoNewLineAtAll (__main__.testmanifestdict)
>  +
>  +Traceback (most recent call last):
>  +  File "/usr/local/google/home/augie/Programming/hg/crew/tests/test-manifest.py", line 344, in testNoNewLineAtAll
>  +    self.fail('Should have raised ValueError')
>  +AssertionError: Should have raised ValueError
>  +FAIL: testNoTerminalNewline (__main__.testmanifestdict)
>  +
>  +Traceback (most recent call last):
>  +  File "/usr/local/google/home/augie/Programming/hg/crew/tests/test-manifest.py", line 337, in testNoTerminalNewline
>  +    self.fail('Should have raised ValueError')
>  +AssertionError: Should have raised ValueError
>  +FAIL: testReversedLines (__main__.testmanifestdict)
>  +
>  +Traceback (most recent call last):
>  +  File "/usr/local/google/home/augie/Programming/hg/crew/tests/test-manifest.py", line 330, in testReversedLines
>  +    self.fail('Should have raised ValueError')
>  +AssertionError: Should have raised ValueError
>  +FAIL: testSetGetNodeSuffix (__main__.testmanifestdict)
>  +
>  +Traceback (most recent call last):
>  +  File "/usr/local/google/home/augie/Programming/hg/crew/tests/test-manifest.py", line 233, in testSetGetNodeSuffix
>  +    self.assertEqual(want, m['foo'])
>  +AssertionError: '\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11a' != '\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11a+'
>
>  ERROR: test-manifest.py output changed
>
> Can you take a look? I'm not immediately sure what's going on, but that's a mostly-standard unittest so it should be pretty straightforward to try and debug?


More information about the Mercurial-devel mailing list