[PATCH 09 of 11 py3] config: open config files as binary explicitly all the time

Augie Fackler raf at durin42.com
Sun Oct 9 10:16:51 EDT 2016


# HG changeset patch
# User Augie Fackler <augie at google.com>
# Date 1476019794 14400
#      Sun Oct 09 09:29:54 2016 -0400
# Node ID f3b993e256a8aeba26d2f927da9cf4428f7f1585
# Parent  2f926a3f2409af24260f826ca1823c564ffea03e
config: open config files as binary explicitly all the time

We had been getting lucky that on posix-like systems the default for
files in Python 2 is binary IO, but now we're explicitly using binary
IO all the time.

diff --git a/mercurial/config.py b/mercurial/config.py
--- a/mercurial/config.py
+++ b/mercurial/config.py
@@ -169,5 +169,5 @@ class config(object):
 
     def read(self, path, fp=None, sections=None, remap=None):
         if not fp:
-            fp = util.posixfile(path)
+            fp = util.posixfile(path, r'rb')
         self.parse(path, fp.read(), sections, remap, self.read)


More information about the Mercurial-devel mailing list