[PATCH 11 of 11 py3] extensions: fix extension module hunting on Python 3

Augie Fackler raf at durin42.com
Sun Oct 9 10:41:21 EDT 2016


> On Oct 9, 2016, at 16:32, Kevin Bullock <kbullock+mercurial at ringworld.org> wrote:
> 
>> On Oct 9, 2016, at 16:16, Augie Fackler <raf at durin42.com> wrote:
>> 
>> # HG changeset patch
>> # User Augie Fackler <augie at google.com>
>> # Date 1476019688 14400
>> #      Sun Oct 09 09:28:08 2016 -0400
>> # Node ID e6a69e778cb02cada23352df512b8580026640d9
>> # Parent  e89f400277d564c4a576ad8e4a6003a201993639
>> extensions: fix extension module hunting on Python 3
>> 
>> importlib is a firm believer that paths are really strings, not
>> bytes. Fortunately we have os.fsdecode to help us with that.
> 
> As I just discovered looking into our current py2.6 breakage on buildbot, importlib doesn't exist at all until 2.7.

Neat. It doesn't actually matter for this series, though the unavailability of os.fsdecode is a bummer for this patch in particular.

> 
> Also a question on this series: no test changes in test-check-py3-compat.t?
> 
> pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
> Kevin R. Bullock
> 



More information about the Mercurial-devel mailing list