[PATCH] py3: refactor token parsing to handle call args properly

Martijn Pieters mj at zopatista.com
Thu Oct 13 05:09:02 EDT 2016


> Nice refactor. While I haven't looked at the code in detail yet, does check-code not complain about the use of underscore_function_names?

Apparently not! I did run the whole test suite, and ran it again just now. Nested function names are locals and exempt from the rule it appears.

Should I resend with adjusted function names?

--
Martijn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20161013/d313f7ff/attachment.sig>


More information about the Mercurial-devel mailing list