[PATCH] py3: refactor token parsing to handle call args properly

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Oct 13 05:19:25 EDT 2016



On 10/13/2016 11:13 AM, Gregory Szorc wrote:
> On Thu, Oct 13, 2016 at 11:09 AM, Martijn Pieters <mj at zopatista.com
> <mailto:mj at zopatista.com>> wrote:
>
>     > Nice refactor. While I haven't looked at the code in detail yet, does check-code not complain about the use of underscore_function_names?
>
>     Apparently not! I did run the whole test suite, and ran it again
>     just now. Nested function names are locals and exempt from the rule
>     it appears.
>
>     Should I resend with adjusted function names?
>
>
> Unless I'm missing something obvious, you should.

+1

> And my guess is someone will patch the style checker to catch nested
> function names :)

+1

This makes a total of +2 ;-)

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list