[PATCH] py3: refactor token parsing to handle call args properly

[Martijn Pieters]

On 13 Oct 2016, at 10:13, Gregory Szorc <gregory.szorc at gmail.com> wrote:
> On Thu, Oct 13, 2016 at 11:09 AM, Martijn Pieters <mj at zopatista.com <mailto:mj at zopatista.com>> wrote:
> > Nice refactor. While I haven't looked at the code in detail yet, does check-code not complain about the use of underscore_function_names?
> 
> Apparently not! I did run the whole test suite, and ran it again just now. Nested function names are locals and exempt from the rule it appears.
> 
> Should I resend with adjusted function names?
> 
> Unless I'm missing something obvious, you should.

Done (bound together with the smaller follow-up patch that I sent as a 2-patch series this time).

--
Martijn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20161013/40fb48fb/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20161013/40fb48fb/attachment.sig>