[PATCH 1 of 6] largefiles: when setting/clearing x bit on largefiles, don't change other bits

Pierre-Yves David pierre-yves.david at ens-lyon.org
Fri Oct 14 15:33:08 EDT 2016



On 10/14/2016 05:29 PM, Yuya Nishihara wrote:
> On Thu, 13 Oct 2016 17:57:57 +0200, Pierre-Yves David wrote:
>> On 10/13/2016 04:13 PM, Yuya Nishihara wrote:
>>> On Thu, 13 Oct 2016 16:03:03 +0200, Mads Kiilerich wrote:
>>>> On 10/13/2016 03:58 PM, Yuya Nishihara wrote:
>>>>> On Thu, 13 Oct 2016 15:46:25 +0200, Mads Kiilerich wrote:
>>>>>> On 10/13/2016 03:39 PM, Yuya Nishihara wrote:
>>>>>>> The series looks good to me. Queued up to the patch 5, thanks.
>>>>>> I have also looked into reworking it to increasing the default chunksize
>>>>>> to 128k everywhere - that seems a bit cleaner in hindsight. I will send
>>>>>> that version if you un-queue it again ;-)
>>>>> Unqueue everything?
>>>>
>>>> I have no changes to the first two so it would be great to keep them ...
>>>> but I could also easily resend them - whatever is least trouble ;-)
>>>
>>> Okay, pruned the following changes from hg-committed:
>>
>> Urg, direct pruning on hg-commmitted is problematic as it makes
>> changesets disappear on the contributor see (see the related thread on
>> the reviewers mailing list a while back and the drophack¹ extension (for
>> reviewers only)).
>>
>> [1] https://www.mercurial-scm.org/repo/evolve/file/tip/hgext/drophack.py
>
> Oh, but my name is not Matt Mackall. :-)
>
> I pruned them assuming Mads would already start working on new version so
> he would have new commits in his local repository.

That asumption might be a bit too optimistic in general (does not really 
matters for Mads as he is not pulling markers anyway.

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list