[PATCH 2 of 2 v2] util: increase filechunkiter size to 128k

Yuya Nishihara yuya at tcha.org
Sun Oct 16 09:23:48 EDT 2016


On Fri, 14 Oct 2016 03:08:25 +0200, Mads Kiilerich wrote:
> # HG changeset patch
> # User Mads Kiilerich <madski at unity3d.com>
> # Date 1476402795 -7200
> #      Fri Oct 14 01:53:15 2016 +0200
> # Node ID 8909ce1593659bce0563cc66ca3fa34525daed65
> # Parent  b7889580507c3d1d40e61904c7a2c2aba335c6cd
> util: increase filechunkiter size to 128k

Queued the series, thanks.

> util.filechunkiter has been using a chunk size of 64k for more than 10 years,
> also in years where Moore's law still was a law. It is probably ok to bump it
> now and perhaps get a slight win in some cases.
> 
> Also, largefiles have been using 128k for a long time. Specifying that size
> multiple times (or forgetting to do it) seems a bit stupid. Decreasing it to
> 64k also seems unfortunate.
> 
> Thus, we will set the default chunksize to 128k and use the default everywhere.

Perhaps there would be no practical difference between 64k and 128k. So
it seems okay to always use 128k.


More information about the Mercurial-devel mailing list