[PATCH 2 of 2 V2] wireproto: compress data from a generator

Pierre-Yves David pierre-yves.david at ens-lyon.org
Mon Oct 17 18:50:18 EDT 2016



On 10/16/2016 08:14 PM, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc at gmail.com>
> # Date 1476641421 25200
> #      Sun Oct 16 11:10:21 2016 -0700
> # Node ID 23457f8910d43bd637b945ced2f963ab71255844
> # Parent  3f18f7464e651128a5f8d9c9312805adbc22f547
> wireproto: compress data from a generator

Pushed, thanks.

It would be great to have some performance number on this,

> […]
>
> To avoid duplicate code, the HTTP groupchunks() has been reimplemented
> in terms of compresschunks().

I would have been happier to take a first patch introducing the new 
function and reimplementing groupchunkgs with it, followed by a second 
patch dropping chunkbuffer. That was minor to ignore but consider doing 
so in the future.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list