[PATCH evolve] tests: use curl instead of wget

[Matt Harbison]

> On Oct 25, 2016, at 4:30 AM, Simon Farnsworth <simonfar at fb.com> wrote:
> 
>> On 25/10/2016 02:34, Matt Harbison wrote:
>> On Mon, 24 Oct 2016 09:37:27 -0400, Simon Farnsworth <simonfar at fb.com>
>> wrote:
>> 
>>>> On 24/10/2016 14:32, Pierre-Yves David wrote:
>>>> 
>>>> 
>>>>> On 10/24/2016 03:26 PM, Simon Farnsworth wrote:
>>>>> # HG changeset patch
>>>>> # User Simon Farnsworth <simonfar at fb.com>
>>>>> # Date 1477315431 25200
>>>>> #      Mon Oct 24 06:23:51 2016 -0700
>>>>> # Branch stable
>>>>> # Node ID 5fbaca977cd43dfd806a3f452543ef0ed4a4732e
>>>>> # Parent  970a4c13ebc320a034bc0aff21e0ef0a84157a92
>>>>> tests: use curl instead of wget
>>>>> 
>>>>> curl is supplied by default on macOS 10.12, but wget isn't. As curl is
>>>>> easy
>>>>> to install on other OSes, just switch the tests over.
>>>> 
>>>> Hum, 4e7da688a066 and 3ffa12edc05a who did the exact opposite 1.5 year
>>>> ago. Can you have a look at them and come back with a plan that fits
>>>> both need?
>>> 
>>> I've looked at the commits you referenced, and there's not enough
>>> context for me to understand why Matt switched from cURL (works on
>>> Linux and macOS by default, needs a package installed on Windows as
>>> far as I understand it), to wget (needs a package installed on Windows
>>> and macOS as far as I understand it).
>>> 
>>> Can you give me context for why you took these two commits?
>> 
>> I didn't get a chance to see if wget was installed on previous versions
>> of OS X before leaving work today, but I don't recall ever having
>> installed it on 10.6 or 10.10.  So maybe that's something new with 10.12?
> 
> I've just checked a 10.10 VM and a 10.11 system, and those did not have wget installed, either (but they did have curl). I can't go back further easily.
> 
> Google tells me that wget is not preinstalled on 10.6 Snow Leopard, either (http://apple.stackexchange.com/questions/12665/how-do-i-get-wget-for-snow-leopard for example); I suspect that you had manually installed wget on your Macs.
> 
>> The reason I switched was because wget is available with msys, but curl
>> isn't.  I dug up some Windows build of curl a few months ago, but don't
>> recall where.  Maybe it's still in my browser history at work.  I seem
>> to have a /mingw/bin/curl on my home system, and vaguely remember
>> building that from source a long time ago.
> It looks like msys doesn't provide curl, but the download "wizard" at https://curl.haxx.se/download.html has current Windows builds listed next to Cygwin builds.

I can't try it at the moment, but that seems easy enough.

> Would you like me to do a v2 of the patch summarizing this discussion and linking to that page in the commit message?

Yes, please.  It's probably worth putting on the wiki page too (I don't have time to find it now, but I vaguely remember one on how to install msys to run the tests on Windows).  I wouldn't necessarily look in the history if I see a command is missing, but if it's on that page when setting up a new system, the problem is avoided entirely.

>> Since I doubt many (any?) people run the tests on Windows, I don't have
>> a problem with switching back, if how to install curl is documented on
>> the page describing how to run tests on Windows.  I forget if I made
>> similar changes in core Mercurial.
> 
> This is the only test suite I run on macOS that uses wget - I run most of the core test suite, so I'd notice if it needed wget. The reason this has become an issue is that I'm shifting from manual builds to automatic builds of the Facebook internal package (which bundles up Mercurial, some extensions, and our configs for our users), and I want to minimise the work we have to do to keep the automatic builds working.

OT: is there a blog or something somewhere that describes how you guys (or any other enterprises) get the developer's system setup and configured?  Things like .hgrc settings, installing and configuring toolchains, staging build scripts, etc.  I think I've read some of Greg's about how Mozilla does it, and we're basically trying to solve the same problems.

> -- 
> Simon Farnsworth