[PATCH 1 of 8 V2] perf: introduce safeattrsetter to replace direct attribute assignment

timeless timeless at gmail.com
Wed Oct 26 14:04:33 EDT 2016


FUJIWARA Katsunori wrote:
> +    If 'ignoremissing' is true, missing 'name' attribute doesn't cause
> +    abortion, and this function returns None. This is useful to

fwiw, this should be `abort`. `abortion` is only used in English with
regards to terminating pregnancies (occasionally it's misused to
describe preventing a pregnancy).

In context, an article ('an') should precede the noun (this applies
regardless of whether it's `abort` or `abortion`).

Note: I understand this is queued, these comments are mostly to help
people learn about how to use various English terms (in some cases to
avoid embarrassment). And also, at some point I hope to review my
emails and supply patches to address any that can be addressed (commit
messages that are public obviously can't be).


More information about the Mercurial-devel mailing list