[PATCH STABLE] build: include a dummy $PATH in the custom environment used by build.py

[Gábor STEFANIK]

>


--------------------------------------------------------------------------
This message, including its attachments, is confidential. For more information please read NNG's email policy here:
http://www.nng.com/emailpolicy/
By responding to this email you accept the email policy.


-----Original Message-----
> From: Mercurial-devel [mailto:mercurial-devel-bounces at mercurial-scm.org]
> On Behalf Of Gábor STEFANIK
> Sent: Friday, October 28, 2016 7:13 PM
> To: Pierre-Yves David <pierre-yves.david at ens-lyon.org>; mercurial-
> devel at mercurial-scm.org
> Subject: RE: [PATCH STABLE] build: include a dummy $PATH in the custom
> environment used by build.py
>
> >
>
>
> --------------------------------------------------------------------------
> This message, including its attachments, is confidential. For more information
> please read NNG's email policy here:
> http://www.nng.com/emailpolicy/
> By responding to this email you accept the email policy.
>
>
> -----Original Message-----
> > From: Pierre-Yves David [mailto:pierre-yves.david at ens-lyon.org]
> > Sent: Friday, October 28, 2016 7:03 PM
> > To: Gábor STEFANIK <Gabor.STEFANIK at nng.com>; mercurial-
> > devel at mercurial-scm.org
> > Subject: Re: [PATCH STABLE] build: include a dummy $PATH in the custom
> > environment used by build.py
> >
> >
> >
> > On 10/28/2016 05:55 PM, Gábor Stefanik wrote:
> > > # HG changeset patch
> > > # User Gábor Stefanik <gabor.stefanik at nng.com> # Date 1477669468 -
> 7200
> > > #      Fri Oct 28 17:44:28 2016 +0200
> > > # Branch stable
> > > # Node ID 3cda0b069802af8b4dbdf9f5598965a522a566b3
> > > # Parent  3afde791dce192f38d8a228ed8e49397e353837e
> > > build: include a dummy $PATH in the custom environment used by
> > > build.py
> > >
> > > This is required for building with pypiwin32, the pip-installable
> > > replacement for pywin32.
> >
> > What does the '.' value means here?
>
> It is supposed to mean $(pwd). Maybe setting to an empty string would be
> safer?

The problem is that pypiwin32 does os.environ['PATH'] += ... in a .pth file (loaded by site.py),
which fails if 'PATH' is not in os.environ.

The original pywin32 doesn't have this issue, but it can only be obtained by downloading
a Windows .exe installer from SourceForge, a site known to have previously injected
malware into .exe installers it hosts.

>
> >
> > >
> > > diff -r 3afde791dce1 -r 3cda0b069802 setup.py
> > > --- a/setup.pyThu Oct 27 20:06:33 2016 +0200
> > > +++ b/setup.pyFri Oct 28 17:44:28 2016 +0200
> > > @@ -167,7 +167,8 @@
> > >  # to not use any hgrc files and do no localization.
> > >  env = {'HGMODULEPOLICY': 'py',
> > >         'HGRCPATH': '',
> > > -       'LANGUAGE': 'C'}
> > > +       'LANGUAGE': 'C',
> > > +       'PATH': '.'}
> > >  if 'LD_LIBRARY_PATH' in os.environ:
> > >      env['LD_LIBRARY_PATH'] = os.environ['LD_LIBRARY_PATH']  if
> > > 'SystemRoot' in os.environ:
> > > _______________________________________________
> > > Mercurial-devel mailing list
> > > Mercurial-devel at mercurial-scm.org
> > > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
> > >
> >
> > --
> > Pierre-Yves David
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel