[PATCH 09 of 12 topics] flake8: fix E501 style

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Sep 6 07:45:34 EDT 2016



On 08/31/2016 07:24 AM, Anton Shestakov wrote:
> On Tue, 30 Aug 2016 20:58:15 -0700
> Sean Farley <sean at farley.io> wrote:
>
>> diff --git a/hgext3rd/topic/evolvebits.py b/hgext3rd/topic/evolvebits.py
>> --- a/hgext3rd/topic/evolvebits.py
>> +++ b/hgext3rd/topic/evolvebits.py
>> @@ -40,14 +40,13 @@ def _orderrevs(repo, revs):
>>
>>  def builddependencies(repo, revs):
>>      """returns dependency graphs giving an order to solve instability of revs
>>      (see _orderrevs for more information on usage)"""
>>
>> -    # For each troubled revision we keep track of what instability if any should
>> -    # be resolved in order to resolve it. Example:
>> -    # dependencies = {3: [6], 6:[]}
>> -    # Means that: 6 has no dependency, 3 depends on 6 to be solved
>> +    # For each troubled revision we keep track of what instability if any
>> +    # should be resolved in order to resolve it. Example: dependencies = {3:
>> +    # [6], 6:[]} Means that: 6 has no dependency, 3 depends on 6 to be solved
>>      dependencies = {}
>>      # rdependencies is the inverted dict of dependencies
>>      rdependencies = collections.defaultdict(set)
>
> I would say line breaks in the original version help readability.

That looks like a very legit feedback, can you resend a version without 
this issue ? thanks.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list