[PATCH 5 of 7 V4] bundle2: add `pushbookmarks` part handler

Stanislau Hlebik stash at fb.com
Tue Sep 6 11:33:06 EDT 2016

But in case of push we also send ‘old’ positions of the bookmarks (they are necessary for bookmarks.pushbookmarks).
So the part handlers should be different, don’t they?

On 9/6/16, 2:01 PM, "Pierre-Yves David" <pierre-yves.david at ens-lyon.org> wrote:

    On 09/05/2016 12:46 AM, Stanislau Hlebik wrote:
    > # HG changeset patch
    > # User Stanislau Hlebik <stash at fb.com>
    > # Date 1473012368 25200
    > #      Sun Sep 04 11:06:08 2016 -0700
    > # Node ID 6d2fbc0ed52b54dfe525063da90973f426f2bcbe
    > # Parent  db526b94eeb678879c2faceb40c64aebbe1054af
    > bundle2: add `pushbookmarks` part handler
    The fact we need two different part  handler with the very same 
    transport is a good hint that something is wrong. This get in 
    perspective with my comment about record in patch 3.
    Without thinking too much about it I don't see any reason why we would 
    need different logic for each direction. Am I missing something?
    Pierre-Yves David

More information about the Mercurial-devel mailing list