[PATCH] evolution: make troubles appear in default log (issue4686)

Kevin Bullock kbullock+mercurial at ringworld.org
Wed Sep 7 15:49:39 EDT 2016


> On Sep 7, 2016, at 14:40, Augie Fackler <raf at durin42.com> wrote:
> 
> On Wed, Sep 7, 2016 at 3:39 PM, Kevin Bullock
> <kbullock+mercurial at ringworld.org> wrote:
>>> On Sep 7, 2016, at 14:23, Augie Fackler <raf at durin42.com> wrote:
>>> 
>>> On Fri, Sep 02, 2016 at 10:26:22AM -0500, Kevin Bullock wrote:
>>>>> On Sep 2, 2016, at 04:38, liscju <piotr.listkiewicz at gmail.com> wrote:
>>>>> 
>>>>> # HG changeset patch
>>>>> # User liscju <piotr.listkiewicz at gmail.com>
>>>>> # Date 1472809041 -7200
>>>>> #      Fri Sep 02 11:37:21 2016 +0200
>>>>> # Node ID 463b164126a0db3f7147787ace34f74deeccc03f
>>>>> # Parent  f148bfa40489269be2e48046734f81065129847a
>>>>> evolution: make troubles appear in default log (issue4686)
>>>>> 
>>>>> This patch is request for comment, it does not update failing
>>>>> test due to new information about troubles, it adds one test
>>>>> to show how troubles looks like in default log.
>>>> 
>>>> I think having a way to show troubled changesets as such in the log is a good idea, but the best we're able to do here is to add a new built-in template (cf. `hg log -T phases`). The default log output is very strongly a part of our command-line API, and changing it (even additively!) is a no-no.
>>> 
>>> There's caselaw for adding new lines to the -Tdefault output
>>> (bookmarks come to mind), so I think we can probably do that?
>> 
>> Why didn't we do it for phases then?
> 
> No idea. Still could for draft/secret if we wanted (unless I'm wrong,
> I can search my mail archive later/at the sprint.)

I'm not sure how bookmarks snuck through, but I was remembering Matt's assessment of the phases addition correctly: <https://bz.mercurial-scm.org/show_bug.cgi?id=3436#c4>

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list