[PATCH 2 of 2 V3] manifest: change manifestctx to not inherit from manifestdict

Durham Goode durham at fb.com
Mon Sep 12 14:03:43 EDT 2016



On 9/12/16 11:01 AM, Durham Goode wrote:
> # HG changeset patch
> # User Durham Goode <durham at fb.com>
> # Date 1473702943 25200
> #      Mon Sep 12 10:55:43 2016 -0700
> # Node ID 1bbdc6966b8fc477538e0a41cafaf07debb0fa05
> # Parent  0570e4b415b5814633cfe1f66b88f487c08cfa17
> manifest: change manifestctx to not inherit from manifestdict
>
> If manifestctx inherits from manifestdict, it requires some weird logic to
> lazily load the dict if a piece of information is asked for. This ended up being
> complicated and unintuitive to use.
>
> Let's move the dict creation to .read(). This will make even more sense once we
> start adding readdelta() and other similar methods to manifestctx.
>
This is the same series that was accepted before, but patch #2 has the 
build break fixed.  The original reason for this being backed out ended 
up being a bug in the evolve extension, which I have also sent a patch 
to fix.


More information about the Mercurial-devel mailing list