[PATCH] lazymanifest: write a more efficient, pypy friendly version of lazymanifest

[Pierre-Yves David]

On 09/12/2016 03:13 PM, Augie Fackler wrote:
> On Mon, Sep 12, 2016 at 02:36:19PM +0200, Maciej Fijalkowski wrote:
>> # HG changeset patch
>> # User Maciej Fijalkowski <fijall at gmail.com>
>> # Date 1473680234 -7200
>> #      Mon Sep 12 13:37:14 2016 +0200
>> # Node ID a43b7edeb6d66afc5c4eab9e4c8bb35b94cbfa97
>> # Parent  df05c43bd1e64f1620d0b2e502f4603c1e5a8341
>> lazymanifest: write a more efficient, pypy friendly version of lazymanifest
>
> Queued this. Looks like a clear improvement over what was there
> before, even with the comments that have questions.

The lack of documentation makes it a bit hard to review but it seems 
overall correct, The LazyManifestIter and LazyManifestIterEntries class 
name are wrong as we don't use CamelCase (so lazymanifestiter and 
lazymanifestiterentries). There is also a small error in the __getitem__ 
error message (says setitem)

However, tests do not pass with this patch so I've dropped it.

Failed test-remove.t: output changed
Failed test-subrepo-deep-nested-change.t: output changed
Failed test-backout.t: output changed
Failed test-rebase-detach.t: output changed
Failed test-transplant.t: output changed
Failed test-manifest.py: output changed and returned error code 1
Failed test-update-issue1456.t: output changed

-- 
Pierre-Yves David