[PATCH 9 of 9 V2] transaction: open a file with checkambig=True to avoid file stat ambiguity

Jun Wu quark at fb.com
Mon Sep 26 11:33:48 EDT 2016


Did you amend the patch to add two lines of comments for
"revlog: specify checkambig at writing to avoid file stat ambiguity"?

  +        #  When True, indexfile is opened with checkambig=True at writing, to
  +        #  avoid file stat ambiguity.
            ^^ - should be one single space

I'd note the spaces are wrong - we may want to add a check-code rule for
this.

Excerpts from Pierre-Yves David's message of 2016-09-23 03:19:34 +0200:
> On 09/22/2016 02:59 PM, FUJIWARA Katsunori wrote:
> > # HG changeset patch
> > # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> > # Date 1474548720 -32400
> > #      Thu Sep 22 21:52:00 2016 +0900
> > # Node ID c47d67e9412df24914ff4caaf1437a2c35a0af6b
> > # Parent  338febde64d5fe6a5aac79aff54741e201b5d88f
> > transaction: open a file with checkambig=True to avoid file stat ambiguity
> 
> I've pushed this. I remember discussing this 1 year ago and I'm very 
> happy to is it happening.
> 
> I've added a small inline comment about the new attribute for revlog.
> 
> Having the same header in each patches might have been a bit overkill. 
> But at least it was clear.
> 
> Cheers,
> 


More information about the Mercurial-devel mailing list