[PATCH 3 of 3] demandimport: error out early on missing attribute of non package (issue5373)

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Sep 27 11:09:31 EDT 2016



On 09/27/2016 04:12 PM, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1474900137 -32400
> #      Mon Sep 26 23:28:57 2016 +0900
> # Node ID 24aee852593b87f35330b9c482c4f2a4a2595e1d
> # Parent  4a8f4b4339238e71ef27a737bb9af2d8b4adb665
> demandimport: error out early on missing attribute of non package (issue5373)
>
> If the parent module isn't a package, all valid attributes must be obtained
> from it. We can raise ImportError early if any attributes not found.

This seems fine. I've pushed it.

I assume this superseed timeless series about reject?

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list