[PATCH] dirstate: rebuild should update dirstate properly
mitrandir at fb.com
Thu Sep 29 11:36:15 EDT 2016
Yeah, the V2 is good to go.
On 9/29/16, 4:25 PM, "Yuya Nishihara" <youjah at gmail.com on behalf of yuya at tcha.org> wrote:
On Tue, 27 Sep 2016 14:06:24 +0000, Mateusz Kwapich wrote:
> On rebuild all the files are set to match the files in the revision but the revision doesn’t provide
> us the correct mtimes to set. I’d argue it’s better to set the mtimes to value explicitly meaning
> “unknown” than to a prepared arbitrary value.
> Same for file mode: why do we even try to guess the file mode on disk?
No idea why. I've checked b304c2496f52, which introduced the test, and
a8f7791e3680, which introduced dirstate.rebuild(). What I can guess from
them is we would set file modes because it was easy at that time.
So I lean toward taking this patch. Is V2 the latest one?
More information about the Mercurial-devel