[PATCH V7] hgweb: expose a followlines UI in filerevision view

[Yuya Nishihara]

On Fri, 31 Mar 2017 18:53:28 -0700, Gregory Szorc wrote:
> On Fri, Mar 31, 2017 at 4:47 AM, Denis Laxalde <denis at laxalde.org> wrote:
> > # HG changeset patch
> > # User Denis Laxalde <denis.laxalde at logilab.fr>
> > # Date 1490819176 -7200
> > #      Wed Mar 29 22:26:16 2017 +0200
> > # Node ID be7965e3afe82be35d258a2cff12b389a857ef88
> > # Parent  dea2a17cbfd00bf08ee87b3e44b1c71499189f89
> > # Available At http://hg.logilab.org/users/dlaxalde/hg
> > #              hg pull http://hg.logilab.org/users/dlaxalde/hg -r
> > be7965e3afe8
> > hgweb: expose a followlines UI in filerevision view
> 
> This looks good to me and I think it can be queued.

Queued per Gregory's review, thanks.

> > diff --git a/mercurial/templates/static/linerangelog.js
> > b/mercurial/templates/static/linerangelog.js
> > new file mode 100644
> > --- /dev/null
> > +++ b/mercurial/templates/static/linerangelog.js
> > @@ -0,0 +1,163 @@
> > +// linerangelog.js - JavaScript utilities for followlines UI
> > +//
> > +// Copyright 2017 Logilab SA <contact at logilab.fr>
> > +//
> > +// This software may be used and distributed according to the terms of the
> > +// GNU General Public License version 2 or any later version.
> > +
> > +//** Install event listeners for line block selection and followlines
> > action */
> > +function installLineSelect() {

Do we need (function () {})() trick to not pollute the global namespace?

> > --- a/mercurial/templates/static/style-paper.css
> > +++ b/mercurial/templates/static/style-paper.css
> > @@ -280,6 +280,46 @@ td.annotate:hover div.annotate-info { di
> >    background-color: #bfdfff;
> >  }
> >
> > +div.overflow pre.sourcelines > span:hover {
> > +  cursor: cell;
> > +}

I saw this cursor in other pages such as "rev/{node}". Perhaps the js
function needs to insert new class to change the cursor?