[PATCH 3 of 3 V2] url: support auth.cookiefile for adding cookies to HTTP requests

Augie Fackler raf at durin42.com
Mon Apr 3 19:59:32 EDT 2017


> On Apr 3, 2017, at 5:50 PM, Gregory Szorc <gregory.szorc at gmail.com> wrote:
> 
> On Mon, Apr 3, 2017 at 2:00 PM, Augie Fackler <raf at durin42.com> wrote:
>> On Tue, Mar 28, 2017 at 08:00:50PM -0700, Gregory Szorc wrote:
>> > # HG changeset patch
>> > # User Gregory Szorc <gregory.szorc at gmail.com>
>> > # Date 1490756307 25200
>> > #      Tue Mar 28 19:58:27 2017 -0700
>> > # Node ID 05b01865ed532a11cd6a824b600876c94c2e293e
>> > # Parent  5cf00a25e8c066bd664dde4cb302bd52a75195d6
>> > url: support auth.cookiefile for adding cookies to HTTP requests
>> 
>> I think I'm fine with these patches as-is. I assume the theory is that
>> this cookie would be checked by some reverse proxy, rather than hgweb
>> itself? Or should we be expecting more changes that introduce
>> cookie-checking hooks of some kind right into hgweb?
>> 
> I have no intent to build server support for cookies at this time.

Hm. I’m not sure if we should do this, or just try and add some sort of more generalized auth helper system. I suspect oauth would be more useful than cookies anyway?

(I’m just torn on the merits of taking these since they’re a feature and not, since there’s no actual way to use them.)


More information about the Mercurial-devel mailing list