[PATCH 4 of 4] hg: make --binary option for Git diffs default to off

Ryan McElroy rm at fb.com
Wed Apr 5 11:37:34 EDT 2017


On 4/5/17 3:59 PM, Yuya Nishihara wrote:
> On Wed, 5 Apr 2017 15:37:51 +0100, Ryan McElroy wrote:
>> On 4/4/17 11:21 PM, Alexander Fomin wrote:
>>> # HG changeset patch
>>> # User Alexander Fomin <afomin at fb.com>
>>> # Date 1491342655 25200
>>> #      Tue Apr 04 14:50:55 2017 -0700
>>> # Node ID 76f6cd23643c9816a688a1e12900a6856c5fabf6
>>> # Parent  373acf7da1a621607a1cc062b96ad67a42a7e016
>>> hg: make --binary option for Git diffs default to off
>> This patch needs a (BC) appended to its title since it changes backwards
>> compatibility.
>>
>> I'd like the community to weigh in on this patch once we have a
>> land-ready version, so I'll wait for the next version before looping in
>> more people to comment/review.
> I like the new behavior, but I think this is a big BC. Maybe we'll have
> to wait for a compat config knob?

Maybe, but it will be good to have a patch in "ready to go mode" 
regardless of whether we can accept it right now or not. Fixing up the 
series is straightforward regardless.


More information about the Mercurial-devel mailing list