[PATCH 4 of 4 NEW-CONCEPT] track-tags: write all tag changes to a file

[Pierre-Yves David]

On 04/05/2017 09:27 PM, Augie Fackler wrote:
>
>> On Apr 4, 2017, at 07:09, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
>>
>>
>>
>> On 04/03/2017 10:50 PM, Augie Fackler wrote:
>>> On Thu, Mar 30, 2017 at 05:03:42PM +0200, Pierre-Yves David wrote:
>>>> # HG changeset patch
>>>> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
>>>> # Date 1490688902 -7200
>>>> #      Tue Mar 28 10:15:02 2017 +0200
>>>> # Node ID 46005886092380991a30c2a02486c2876ecac341
>>>> # Parent  2dcaa99d6160561166269f192a89b25f84fd4667
>>>> # EXP-Topic tags
>>>> # Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
>>>> #              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r 460058860923
>>>> track-tags: write all tag changes to a file
>>>
>>> Overall, the feature seems reasonable, and having the hook information
>>> seems right.
>>
>> Status of this series is a bit unclear to me. Do you need me to do anything ?
>
> I guess I'd like others to comment on the way you're passing data into the hooks. It feels a little odd to me.

Can you elaborate on what feels odds?

The amount of data can be arbitrarily large so we cannot use an 
enviromnent variable. We could have a hooks call a dedicated mercurial 
commands but that would be a bit odd and slower since we loop back into 
Mercurial.


-- 
Pierre-Yves David