[PATCH 3 of 3 v2] hg: make --binary option for git diffs default to off (BC)
yuya at tcha.org
Thu Apr 6 08:31:56 EDT 2017
On Thu, 6 Apr 2017 10:09:48 +0100, Ryan McElroy wrote:
> On 4/5/17 11:51 PM, Alexander Fomin wrote:
> > # HG changeset patch
> > # User Alexander Fomin <afomin at fb.com>
> > # Date 1491431909 25200
> > # Wed Apr 05 15:38:29 2017 -0700
> > # Node ID f3814cce4dda8e8090736f642b694ce7cd3792bb
> > # Parent 900f393807023064cb484e86e3ccffa6338b55bb
> > hg: make --binary option for git diffs default to off (BC)
> Awesome! This series looks good to me. We have to have a broader
> discussion about the BC break in this last patch (it will probably break
> a lot of --git users, but it seems "more correct" -- is it worth it?),
> but the first two seem like pretty straightforward improvements to me.
> I've marked them as pre-reviewed in patchwork.
I don't think this is trivial enough to change now. I vote against it.
Also, "git format-patch", which I think is equivalent to "hg export", includes
binary diff by default.
More information about the Mercurial-devel