[PATCH 1 of 2] hgweb: add a floating tooltip to invite on followlines action

Yuya Nishihara yuya at tcha.org
Sun Apr 9 01:12:31 EDT 2017


On Fri, 07 Apr 2017 10:55:41 +0200, Denis Laxalde wrote:
> # HG changeset patch
> # User Denis Laxalde <denis.laxalde at logilab.fr>
> # Date 1491498909 -7200
> #      Thu Apr 06 19:15:09 2017 +0200
> # Node ID e8cc0233064b9aaf4e99efa960d857c9884266c4
> # Parent  e0dc40530c5aa514feb6a09cf79ab6a3aa2ec331
> # Available At http://hg.logilab.org/users/dlaxalde/hg
> #              hg pull http://hg.logilab.org/users/dlaxalde/hg -r e8cc0233064b
> hgweb: add a floating tooltip to invite on followlines action

The UI looks nice. Queued, thanks.

> @@ -83,13 +115,25 @@ document.addEventListener('DOMContentLoa
>              // remove this event listener
>              sourcelines.removeEventListener('click', lineSelectEnd);
>  
> +            // hide tooltip and disable motion tracking
> +            tooltip.classList.add('hidden');
> +            sourcelines.removeEventListener('mousemove', moveAndShowTooltip);
> +            window.clearTimeout(tooltipTimeoutID);

We could check if tooltipTimeoutID is undefined here, but that wouldn't
actually happen. So this code seems fine.


More information about the Mercurial-devel mailing list