[PATCH 2 of 2] filelog: use slow path to calculate size

Yuya Nishihara yuya at tcha.org
Mon Apr 10 09:06:45 EDT 2017


On Sun, 9 Apr 2017 12:37:37 -0700, Jun Wu wrote:
> Excerpts from Yuya Nishihara's message of 2017-04-09 13:45:37 +0900:
> > It seems filelog.renamed() is optimized for a common case where p1 isn't
> > null. Maybe we'll need some benchmarks to see if the fast path is worth
> > preserving the buggy behavior.
> 
> Although "hg status" time seems unchanged because modified files are
> limited, a quick benchmark shows "debugfileset size(1k)" increases from 0.1
> to 0.5 seconds. I guess that means we probably still need to maintain the
> "-4" hack.

Agreed. Thanks for measuring that.

> Maybe a more advanced revlog data format can handle that cleanly.

Perhaps. The '\1' escape is annoying and error-prone.


More information about the Mercurial-devel mailing list