[PATCH 8 of 8] obsolescence: add test case D-4 for obsolescence markers exchange

Sean Farley sean at farley.io
Fri Apr 14 14:37:15 EDT 2017


Pierre-Yves David <pierre-yves.david at ens-lyon.org> writes:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> # Date 1491836116 -7200
> #      Mon Apr 10 16:55:16 2017 +0200
> # Node ID c482cba3fbe734de7968451cabea051644c292c4
> # Parent  fa5b063a757a69b5ddba307bb579312bb67b5c37
> # EXP-Topic exchange.obsmarkers
> # Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
> #              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r c482cba3fbe7
> obsolescence: add test case D-4 for obsolescence markers exchange
>
> About 3 years ago, in August 2014, the logic to select what markers to select on
> push was ported from the evolve extension to Mercurial core. However, for some
> unclear reasons, the tests for that logic were not ported alongside.
> I realised it a couple of weeks ago while working on another push related issue.
> I've made a clean up pass on the tests and they are now ready to integrate the
> core test suite. This series of changesets do not change any logic. I just adds
> test for logic that has been around for about 10 versions of Mercurial.
>
> They are a patch for each test case. It makes it easier to review and postpone
> one with documentation issues without rejecting the wholes series.
>
> This patch introduce case D-4: unknown changeset in between known on
>
> Each test case comes it in own test file. It help parallelism and does not
> introduce a significant overhead from having a single unified giant test file.
> Here are timing  to support this claim.

Sure, seems fine to me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170414/1efc0453/attachment.sig>


More information about the Mercurial-devel mailing list