[PATCH remotenames] remotenames: fix parameter ordering

Ryan McElroy rm at fb.com
Wed Apr 19 09:38:47 EDT 2017


On 4/18/17 9:55 PM, Wez Furlong wrote:
> # HG changeset patch
> # User Wez Furlong <wez at fb.com>
> # Date 1492546015 25200
> #      Tue Apr 18 13:06:55 2017 -0700
> # Node ID 87fa8cb8721726dcbe2c6a313b70ac770e0fc5ae
> # Parent  b55f98398522d9c7cf81ab191ddd322926699b0a
> remotenames: fix parameter ordering

Thanks for the fix!

>
> Summary: templater function signature changed upstream
>
> Test Plan: rt
>
> Reviewers: #mercurial, quark
>
> Reviewed By: quark
>
> Differential Revision: https://phabricator.intern.facebook.com/D4908240
>
> Signature: t1:4908240:1492545063:0d726e99e065bf231a2fcf894a1722e02e038650

All this facebooky phabricator stuff isn't super helpful on the list :-p

>
> diff --git a/remotenames.py b/remotenames.py
> --- a/remotenames.py
> +++ b/remotenames.py
> @@ -1723,8 +1723,8 @@
>       if (not remotenames or not suppress) and 'remotebranches' in repo.names:
>           remotenames += repo.names['remotebranches'].names(repo, ctx.node())
>   
> -    return templatekw.showlist('remotename', remotenames,
> -                               plural='remotenames', **args)
> +    return templatekw.showlist('remotename', remotenames, args,
> +                               plural='remotenames')
>   
>   #############################
>   # bookmarks api compatibility
>

I'll take this upstream with changes to the commit message in-flight.


More information about the Mercurial-devel mailing list