stable ordering of test output

Jun Wu quark at fb.com
Wed Apr 19 18:48:00 EDT 2017


I'm +1 on this patch. It does not look harmful.

Excerpts from Augie Fackler's message of 2017-04-19 15:22:42 -0400:
> >> I'm not sure what this condition is intended for. It's always true for
> >> write() because r is None and data is a str.
> >
> > This forwarder is also used for read(), where data is the number of
> > bytes to be read. At least, I think that’s right, now I’m doubting
> > myself.
> 
> Should I go ahead and mail this patch? Perhaps with some extra
> comments? Or do people object to this fix?


More information about the Mercurial-devel mailing list