[PATCH 2 of 2] show: add basic labels to work template

Yuya Nishihara yuya at tcha.org
Fri Apr 21 09:15:40 EDT 2017


On Thu, 20 Apr 2017 23:45:53 -0700, Gregory Szorc wrote:
> On Thu, Apr 20, 2017 at 10:06 AM, Sean Farley <sean at farley.io> wrote:
> > Gregory Szorc <gregory.szorc at gmail.com> writes:
> > > # HG changeset patch
> > > # User Gregory Szorc <gregory.szorc at gmail.com>
> > > # Date 1492539008 25200
> > > #      Tue Apr 18 11:10:08 2017 -0700
> > > # Node ID 7f5f78179f5f6afc0f4bea52aa03f1431e03d3d9
> > > # Parent  d8d4b4acc68859f90f8759309803b116b67a9371
> > > show: add basic labels to work template
> > >
> > > `hg show work` is much more usable if output is colored. This patch
> > > implements coloring via label() in a very hacky way.
> > >
> > > In a default Mercurial install, you'll see yellow node labels for all
> > > phases. Branches and bookmarks use the same formatting as the commit
> > > message. So this change doesn't help much in a default install. But if
> > > you have a custom colors defined for these things, output is much more
> > > readable.
> > >
> > > The implementation obviously needs some work. But for a minor change
> > > on a feature that isn't convered by BC, this seems like a clear win
> > > for the feature in 4.2.
> >
> > Do we add this after the rc now? My guess is no but it does seem nice
> > for 4.2 (shrug)
> >
> 
> I thought I would get these in before 4.2 RC. I guess not. Given the highly
> experimental nature of show, I'd still like to sneak them in if possible.

Is it generally allowed to take this kind of patches during freeze? I don't
want to waste time deciding which is good or bad for stable.

FWIW, these patches look good.


More information about the Mercurial-devel mailing list