[PATCH v2 stable] sshpeer: try harder to snag stderr when stdout closes unexpectedly

Yuya Nishihara yuya at tcha.org
Fri Apr 21 23:26:41 EDT 2017


On Fri, 21 Apr 2017 16:32:32 -0400, Augie Fackler wrote:
> # HG changeset patch
> # User Augie Fackler <augie at google.com>
> # Date 1492114180 14400
> #      Thu Apr 13 16:09:40 2017 -0400
> # Branch stable
> # Node ID 8862fd11cc7d27512a4b4c2a56c983d68609660b
> # Parent  6e0368b6e0bb2aa5210daec091c0200583553a78
> sshpeer: try harder to snag stderr when stdout closes unexpectedly
> 
> Resolves test failures on FreeBSD, but I'm not happy about the fix.

Queued, thanks.

> A previous version of this also wrapped readline by putting the hack
> in the _call method on doublepipe. That was confusing for readers and
> wasn't necessary - just doing this on read() is sufficient to fix the
> bugs I'm observing. We can always come back and do readline later if
> needed.

write() was also wrapped.


More information about the Mercurial-devel mailing list