[PATCH stable] tests: work around flaky test failure on FreeBSD and relatives

[Anton Shestakov]

On Sat, 22 Apr 2017 14:30:27 -0400
Augie Fackler <raf at durin42.com> wrote:

> # HG changeset patch
> # User Augie Fackler <augie at google.com>
> # Date 1492878287 14400
> #      Sat Apr 22 12:24:47 2017 -0400
> # Branch stable
> # Node ID af4f0c00735ad4d734407c627bb3e1c080d583ad
> # Parent  befefdd34cf80d4604ee96899196d946a0058e9f
> tests: work around flaky test failure on FreeBSD and relatives
> 
> test-http-bad-server has a flaky output case that reproduces fairly
> often (20% or more of runs on my Mac) on BSD-family OSes. So that
> tests can be green for the 4.2 release, let's more or less give up on
> this output, and plan to pursue it in the future.
> 
> diff --git a/tests/test-http-bad-server.t b/tests/test-http-bad-server.t
> --- a/tests/test-http-bad-server.t
> +++ b/tests/test-http-bad-server.t
> @@ -48,9 +48,17 @@ Failure immediately after accept() shoul
>    $ hg --config badserver.closeafteraccept=true serve -p $HGPORT -d --pid-file=hg.pid
>    $ cat hg.pid > $DAEMON_PIDS
>  
> +TODO: this usually outputs good results, but sometimes emits abort:
> +error: '' on FreeBSD and OS X.

On Ubuntu apparently too:
https://launchpadlibrarian.net/316157590/buildlog_ubuntu-xenial-amd64.mercurial_4.2~rc~xenial1_BUILDING.txt.gz

> +What we ideally want are:
> +
> +abort: error: Connection reset by peer (no-windows !)
> +abort: error: An existing connection was forcibly closed by the remote host (windows !)
> +
> +The flakiness in this output was observable easily with
> +--runs-per-test=20 on macOS 10.12 during the freeze for 4.2.
>    $ hg clone http://localhost:$HGPORT/ clone
> -  abort: error: Connection reset by peer (no-windows !)
> -  abort: error: An existing connection was forcibly closed by the remote host (windows !)
> +  abort: error: * (glob)
>    [255]
>  
>    $ killdaemons.py $DAEMON_PIDS
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel