[PATCH 1 of 2 STABLE] diffhelpers: add canstripcr=True to fix_newline

Augie Fackler raf at durin42.com
Tue Apr 25 18:20:06 EDT 2017


> On Apr 25, 2017, at 18:19, Sean Farley <sean at farley.io> wrote:
> 
> Augie Fackler <raf at durin42.com> writes:
> 
>>> On Apr 25, 2017, at 17:11, Sean Farley <sean at farley.io> wrote:
>>> 
>>>> The problem is new python code won't work with old .so files. But that does
>>>> not sound like a strict rule we have to maintain. Bisect users could still
>>>> build the new version first and start bisecting without rebuild.
>>> 
>>> I'm not sure if we want to change this policy (perhaps) but mpm rarely
>>> broke this in years past:
>> 
>> It's fine with me to require people that are bisecting to need a newer .so - that's mostly what you should have sitting around anyway for perf reasons.
> 
> In the first email, mpm notes that this will break people that 'hg pull
> --update' as a way to 'compile'. I think that's a bigger problem than
> bisecting, in this particular case.

Valid point. For now, let's preserve that invariant - Jun, can you make sure v2 has a graceful degradation path if it gets an old .so?

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170425/af5c3919/attachment.sig>


More information about the Mercurial-devel mailing list