[PATCH 1 of 2 STABLE] diffhelpers: add canstripcr=True to fix_newline

Jun Wu quark at fb.com
Tue Apr 25 19:01:37 EDT 2017


Excerpts from Sean Farley's message of 2017-04-25 15:19:07 -0700:
> Augie Fackler <raf at durin42.com> writes:
> 
> >> On Apr 25, 2017, at 17:11, Sean Farley <sean at farley.io> wrote:
> >> 
> >>> The problem is new python code won't work with old .so files. But that does
> >>> not sound like a strict rule we have to maintain. Bisect users could still
> >>> build the new version first and start bisecting without rebuild.
> >> 
> >> I'm not sure if we want to change this policy (perhaps) but mpm rarely
> >> broke this in years past:
> >
> > It's fine with me to require people that are bisecting to need a newer .so - that's mostly what you should have sitting around anyway for perf reasons.
> 
> In the first email, mpm notes that this will break people that 'hg pull
> --update' as a way to 'compile'. I think that's a bigger problem than
> bisecting, in this particular case.

fwiw 16bafcebd3d1 is mpm's commit that breaks the rule you're talking about.


More information about the Mercurial-devel mailing list